Skip to content

feat: OCS Calendar Import#55178

Open
SebastianKrupinski wants to merge 1 commit into
masterfrom
feat/calendar-import-export-ocs
Open

feat: OCS Calendar Import#55178
SebastianKrupinski wants to merge 1 commit into
masterfrom
feat/calendar-import-export-ocs

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Extracted from #49995

This adds the ability to export and import calendars via the OCS

OCS Import

Endpoint: /ocs/v2.php/calendar/import
Request: POST

{
	"transaction": "random string",
	"target": "personal",
	"options": {
		"format": "xcal", (optional "ical, jcal, xcal", defaults to "ical")
		"validation": 0, (0 - no validate, 1 - validate and skip, 2 - validate and error)
		"errors": 0, (0 - continue, 1 - fail)
		"supersede": true,
	},
	"user": "user1", (optional admin permissions required)
	"data": "<?xml version=\"1.0\" encoding=\"UTF-8\"?><calendar><event><title>Meeting</title><date>2025-02-18</date></event></calendar>"
}

Checklist

@SebastianKrupinski
SebastianKrupinski requested a review from a team as a code owner September 18, 2025 19:28
@SebastianKrupinski
SebastianKrupinski requested review from CarlSchwan, icewind1991 and nfebe and removed request for a team September 18, 2025 19:28
@SebastianKrupinski SebastianKrupinski self-assigned this Sep 18, 2025
@SebastianKrupinski SebastianKrupinski added the 2. developing Work in progress label Sep 18, 2025
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 12ad7af to 6838bbe Compare September 23, 2025 00:15
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch 3 times, most recently from e000a47 to a3431ef Compare September 23, 2025 00:57
provokateurin
provokateurin previously requested changes Sep 28, 2025
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code comments in the controller are a bit useless, you might want to remove them to avoid confusion if the code is refactored later.

Comment thread apps/dav/lib/Controller/CalendarExportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarExportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarImportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarExportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarImportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarImportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarExportController.php Outdated
Comment thread apps/dav/lib/Controller/CalendarImportController.php Outdated
Comment thread lib/public/AppFramework/Http/StreamGeneratorResponse.php Outdated
Comment thread lib/public/AppFramework/Http/StreamGeneratorResponse.php Outdated
@SebastianKrupinski SebastianKrupinski mentioned this pull request Oct 15, 2025
Open
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from a3431ef to 3e048d5 Compare October 15, 2025 23:53
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 2ac397f to 20a731c Compare October 19, 2025 18:23
@SebastianKrupinski SebastianKrupinski mentioned this pull request Nov 13, 2025
Closed
@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 7, 2026
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 20a731c to 0ad93ad Compare June 9, 2026 21:25
@SebastianKrupinski SebastianKrupinski mentioned this pull request Jun 10, 2026
Open
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 0ad93ad to 56838c2 Compare June 10, 2026 16:31
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Jun 10, 2026
@SebastianKrupinski SebastianKrupinski changed the title feat: OCS Calendar Export + Import feat: OCS Calendar Import Jun 10, 2026
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch 2 times, most recently from 45970d0 to 0ea9465 Compare June 10, 2026 18:24
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch 6 times, most recently from 6631397 to d0e8053 Compare June 12, 2026 19:22
@SebastianKrupinski SebastianKrupinski mentioned this pull request Jul 14, 2026
Draft
8 tasks
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from d0e8053 to 4d7c277 Compare July 14, 2026 14:06
@SebastianKrupinski
feat: OCS Calendar Export + Import
085f3d4 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 4d7c277 to 085f3d4 Compare July 14, 2026 17:35
ChristophWurst
ChristophWurst reviewed Jul 15, 2026
View reviewed changes
Comment thread apps/dav/lib/CalDAV/Import/ImportEvent.php

use JsonSerializable;

interface ImportEvent extends JsonSerializable {

@ChristophWurst ChristophWurst Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #61277 (comment)

ChristophWurst
ChristophWurst reviewed Jul 15, 2026
View reviewed changes
Comment thread lib/public/AppFramework/Http/StreamGeneratorResponse.php
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCP\AppFramework\Http;

@ChristophWurst ChristophWurst Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new public API. this is going to be messy in the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner
@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews

Projects

💌 📅 👥 Groupware team
Status: 🏗️ In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianKrupinski @ChristophWurst @provokateurin